I'm almost ready to upload my new sit to my Sdrive and will be having my domain transferred over. Does it matter if I upload my site before the transfer or should I wait for when the transfer to complete.
Does it matter either way?

Update your site whenever it'd ready to be published (error checking completed testing etc.)