Theme code seems wrong - Post ID 183438

User 38401 Photo


Senior Advisor
10,951 posts

When VSD Opens, if you have the splash screen that has all the options of how to work on a site you should see a long button for starting a new site using a Theme. If you have that splash screen turned off, then go to File at the top left and in that menu choose New from Theme. Click that and it will open the dialog box for which theme you want to use and all the themes that are included with VSD are in the default selection which you see on the top left. The themes show in the bottom left and the previews to the right.

That will give you previews for all of the included themes.

Other than that I would also suggest the same as SirAGE and Inger, pull out the parts you want and code it yourself if the style is what you're after. VSD code is extremely different from typical HTML code and although it's doable to edit it, it's definitely not optimal at all if you're a coder at heart. :)
User 601710 Photo


Registered User
114 posts

I think you all have missed my point here as the suggestions are what I have done already with the theme that CAME WITH VSD! I checked the themes I did buy and Haunted Manor is not among them. As Scott said, it is ten years old, but came with original version of VSD I bought and has remained in the list through VSD updates (as it should).

I didn't say the theme is wrong. Just that the code did not validate and I made a "suggestion" that it should. If I'd known at the time it was that old, I would have checked another theme. I have replaced the HTML and CSS to meet XHTML Strict. All the suggestions made are what I have already thought about or am doing now. Just wanted to know what default themes were in latest version of VSD so I can check the coding. I may even go so far as to remove all the absolute positioning in any theme, but that's for later.
Ron
User 601710 Photo


Registered User
114 posts

OK. Opened Audible Odyssey that Scott says come with VSD. Checked only the index.html file in the HTML Editor and it has similar coding errors:

<img src="files/IMG_0.jpg" alt="" width="959px" height="330px">
Every image tag has the same errors.

At least there were no tables in this one. :P
Ron
User 38401 Photo


Senior Advisor
10,951 posts

what errors are you seeing there? either I'm blind or there are no errors there. Yeah tables haven't been in most of the themes for a while now which is a good thing, but....

If you want you can get specific help here too if there's certain things you need help with. Other than that I don't know what else to tell you on it. The theme is old so the code isn't going to validate correctly which would be expected. I would highly suggest you go through your themes and find out which ones are that old and remove them from the VSD setup. I don't know why they would still be there even, but either way if they are that old, really that's so much work to fix why would you bother to do that even? There are so many themes out there built for coders, why use up so much time and effort on one that old? Truly there has to be an HTML template that is close enough to it to give you a start that you can replicate the theme look with? Just curious there I guess :)
User 2073552 Photo


Registered User
1,625 posts

Just code it yourself, if you are a code stickler then why use a theme in the first place? Build it yourself... Because as it stands now, on your site you have this listed as a theme you built. Which it is not, and you have the CSS listed as css that you have built, which it is not. Now, I suggest you build your own theme, using the same images as the manor one. THEN you can claim it as your own work. But as EVERYONE Has said... The Theme is 5 years old and has not been updated... This means we get the code is old.

Oh one more thing... That img code you posted... There are no errors in it. HTML5 has given the img tag as self closing.
"An Apple doth not fall far from its tree, yet an orange does."

https://lbwebsitedesign.com - Responsive Web Design & Web Hosting Services.
http://helpsite.sirage.com - HTML5, CSS3 and CC Help Video Blog.
User 601710 Photo


Registered User
114 posts

I knew no one would catch the errors in the image tags. :P You do not give a dimension for the width/height when using the width="" and height="" attributes.

Wish people would quit telling me what I need to do. I don't care how old the templates are. Just pointing out the coding is incorrect. You can edit them yourself or leave the templates as is and use directly from VSD. I will be making my own themes with VSD. Too bad you can't import the files made in the HTML Editor and make a theme with them using the *.vnu extension. I use whatever tool I want at the time. The HTML Editor once site has been designed in VSD and VSD to design one with or without a default theme.

@Jo Ann: THe VSD program is the latest build and the Audible Odyssey theme is the default theme that came with the download. All the other themes must not be old either since they came with the latest version of VSD. Too bad you also can not import and convert other non-CC themes. :P
Ron
User 122279 Photo


Senior Advisor
14,649 posts
Online Now

My point by telling you that the Haunted manor theme was a tad older than the latest release of VSD, was to illustrate that tables maybe were still being used for layout when that theme was 'born'.

I don't think I'm telling you what to do. Quite on the contrary, I was asking you why you kept messing with VSD when you obviously know how to code yourself. And then I said what I would do if I really really really wanted to use a VSD theme in the Editor.

I don't know the 'back end stuff' in VSD, why things have to be the way they are. But VSD works for those who don't know coding, and that is the whole purpose of it.
Ha en riktig god dag!
Inger, Norway

My work in progress:
Components for Site Designer and the HTML Editor: https://mock-up.coffeecup.com


User 2073552 Photo


Registered User
1,625 posts

Ron wrote:
I knew no one would catch the errors in the image tags. :P You do not give a dimension for the width/height when using the width="" and height="" attributes.


You do not have to include dimensions attributes. That is correct, but you should ALWAYS include them for the reason that the browser has to then look at the image properties to find the image dimensions which in turn makes the page load longer. Now if you only have 2 or three images on a page, then that is fine, but if you have a lot of them, then you should always include the dimensions with the image tag...
"An Apple doth not fall far from its tree, yet an orange does."

https://lbwebsitedesign.com - Responsive Web Design & Web Hosting Services.
http://helpsite.sirage.com - HTML5, CSS3 and CC Help Video Blog.
User 38401 Photo


Senior Advisor
10,951 posts

Ok so let's agree to let this go as I don't believe there is anything to help with in this thread if the original poster is not needing help. The suggestion was just that, and ended up being null only because the theme being used is no longer in use with the VSD program and is therefore a moot point on it needing to be updated so in the end, I think this thread is pretty much answered and then some.
User 601710 Photo


Registered User
114 posts

Before letting it go, let me clear one thing up for SirAGE: The errors in the image tags are the dimensions to the width/height attributes. These are the errors:

<img src="files/IMG_0.jpg" alt="" width="959px" height="330px">


Should be:

<img src="files/IMG_0.jpg" alt="" width="959" height="330">


Or, with the dimensions, you can use inline CSS:

<img src="files/IMG_0.jpg" alt="" style="width: 959px; height: 330px;">


Dimensions are "px"s in this case and not the attributes used.

That's all folks....
Ron

Have something to add? We’d love to hear it!
You must have an account to participate. Please Sign In Here, then join the conversation.