Theme code seems wrong - Post ID 182995

User 601710 Photo


Registered User
114 posts

OK, I'm gonna make this as a suggestion as many are not as much a stickler for correct code as I am. Would someone go through VSD and get the themes used to have correct code? Example of one theme:

<div id="background" style="position:absolute; top:0px; left:0px; z-index:0;">
<table style="height:768px; background-image: url('files/WP4bck.jpg');" width="1024px" border="0" cellspacing="0" cellpadding="0">
<tr>
<td>
<br>
</td>
</tr>
</table>
</div>

Now that is not needed to have table tags inside the background div which really doesn't validate even with the basic doctype VSD uses. Nor was it needed to use inline CSS for the div tag when there is embedded CSS on the page. I am a little surprised that these themes do not come with their own separate CSS file. As it is, I'll be re-coding the entire theme I am currently using which means there is no time saved here using VSD.
Ron
User 122279 Photo


Senior Advisor
14,649 posts

This must have been something created several years ago. It certainly needs to be updated.

But a question to you, Ron: If you are able to write code, why using VSD at all?
Ha en riktig god dag!
Inger, Norway

My work in progress:
Components for Site Designer and the HTML Editor: https://mock-up.coffeecup.com


User 38401 Photo


Senior Advisor
10,951 posts

Just a question Ron on the theme. Is this a default theme or a purchased theme from CC? If default, are you using the most recent build of VSD? Just want to rule out that the theme itself is not old. :)
User 601710 Photo


Registered User
114 posts

VSD is the latest version and it is one of the templates that comes with it. In fact, all the templates are ones I have to recode, but that's OK. I love coding. Just nice to have a basic start although it would be nice if all themes were XHTML 1.0 Strict and not HTML 4.01 Transitional. Then I could just add any new images and the text content. Don't forget...it's just a suggestion. Maybe you can send me the themes and I'll recode them for CC. :P

VSD Version is 7.0.24.0. Theme is the Haunted Manor.
Ron
User 122279 Photo


Senior Advisor
14,649 posts

The Haunted Manor theme doesn't come with the latest version of VSD. It must have come from an earlier version.

I have checked some of the versions that do come with the latest VSD. They have a one cell layout table, and I tried to rename it div id="wrapper" instead and deleted the table rows and cells, and it didn't make any difference in the layout.
Ha en riktig god dag!
Inger, Norway

My work in progress:
Components for Site Designer and the HTML Editor: https://mock-up.coffeecup.com


User 601710 Photo


Registered User
114 posts

The VSD Haunted Manor has a one cell table used for the header (which I removed). Even it was coded incorrectly, but that's not what I am getting at. The theme mixes table tags and absolutely placed divs. I redid the CSS and put all pages to be styled from one CSS file. No biggie there either. The theme looks exactly as it did before editing. Too bad I can't change the actual theme code that uses .vnu extention. Or, can I? This theme uses more images than it needs because each page uses the same images except each has a different class object name. No biggie there either as that would be easily changed.

I realize that these themes are made for people using VSD because it IS a visual site design program. Just a stickler for well written code and these themes do not fully validate originally.

What theme comes with latest version of VSD? I'll look at HTML/CSS and see what it looks like.
Ron
User 601710 Photo


Registered User
114 posts

Since I got an email that this was moved because it's not a suggestion, but a problem with the theme, I'll ask again: What theme comes with latest version of VSD? I'll look at HTML/CSS and see what it looks like. This will help me tell whether all themes are coded the same. I just do not know which themes come with latest build of VSD. I have not bought any for this program and I just did another install of VSD on Mar 3, 2012.

Only files up to and including the News link have been recoded. Haunted Manor
Ron
User 103173 Photo


VP of Software Development
0 posts

That theme is a good 5+ years old and was phased out in VSD 5.7. Themes included with VSD 7.0:
  • Audible Odyssey
  • Business and Usual
  • Cartoon Dreams
  • Casual Friday
  • Hopscotch
  • Listen Up
  • Miami
  • Organic Vibrance
  • Steve Reich
  • Sturdy Past

These themes were specifically designed for VSD, so using them in an HTML editor may not give you the most desirable results.
Learn the essentials with these quick tips for Responsive Site Designer, Responsive Email Designer, Foundation Framer, and the new Bootstrap Builder. You'll be making awesome, code-free responsive websites and newsletters like a boss.
User 2073552 Photo


Registered User
1,625 posts

To be honest, if you really want this theme, just take the background images, and reuse them in a theme you build yourself. Or just place them into another theme all together.
"An Apple doth not fall far from its tree, yet an orange does."

https://lbwebsitedesign.com - Responsive Web Design & Web Hosting Services.
http://helpsite.sirage.com - HTML5, CSS3 and CC Help Video Blog.
User 122279 Photo


Senior Advisor
14,649 posts

If I spotted a VSD theme that I liked, but wanted to use it for the Editor (and if there was no corresponding theme for the Editor), I would open it in VSD, save it in order to have the output files, open them in the Editor and then pull out the css from the html files and pop it into its own css file, and of course rewrite the css so that the same objects, fonts etc could be used several times. A lot of work, so I don't think I'd really bother, but instead write my own css to match the look of the theme.
Ha en riktig god dag!
Inger, Norway

My work in progress:
Components for Site Designer and the HTML Editor: https://mock-up.coffeecup.com



Have something to add? We’d love to hear it!
You must have an account to participate. Please Sign In Here, then join the conversation.